Conversation
Meta deprecated page_impressions_unique and page_impressions_organic_unique (all API versions), which silently zeroed out reach in the weekly FB report. Total reach now uses page_total_media_view_unique (true unique-reach replacement); organic reach uses page_media_view broken down by is_from_ads since Meta removed the organic unique-reach metric with no replacement. Also adds get_weekly_paid_views for the same is_from_ads breakdown. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Telegram's broadcast stats API reports each photo in a gallery post as a separate message with the same view count, which inflated new_posts_count and recent_message_views by the album size (e.g. a 9-photo post counted as 9 new posts and 9x its views). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
conftest.py and several test files still imported the deleted src.trello.trello_client/trello_objects modules and exercised APIs (use_focalboard/use_planka kwargs, TrelloCard.to_dict(), idBoard key) that no longer exist after the Planka migration, so the whole suite failed to even collect. Removes the dead mock_trello fixture and test_trello_client.py (which tested the deleted TrelloClient), updates stale imports to src.planka.board_objects, and aligns test expectations with current handler signatures and object field names. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tg_analytics_report_job.py) counting each photo in a multi-image album post as a separate new post and multiplying its views by the album size (Telegram's broadcast stats API reports one entry per message, not per visual post).conftest.pyand several test files still referencedsrc.trello.trello_client/trello_objects, deleted during the earlier Trello->Planka migration, along with other stale fixtures/signatures (use_focalboard/use_plankakwargs,TrelloCard.to_dict(),idBoardkey) that no longer exist.Test plan
pytest tests/unit/— 42 passed, 4 skipped, 2 xfailed (previously failed to collect)_deduplicate_albumsconfirms a 9-photo album + 2 singles collapses to 3 posts with correct summed views